Easier process to add as friend after expense creation error
complete
Rica Zhang
Right now if you try to create an expense in a group with people you aren’t friends yet, it shows an error message. But there’s no easy way to add the person as friend and then go back to submitting your expense.
The current flow I went through was:
1) i didn’t realize this was a requirement so I already typed in all the details of the expense before hitting the error. You have to exit out of the expense you already typed in and lose all the progress
2) I went to the group details to try to click on their profile but the list of people is not clickable.
3) I went to the search bar at the top to copy the friends email address but that didn’t work because that only searches existing friends.
4) Then I found the add friend button and added them.
5) Then I went back to add an expense and all the stuff I had typed in was lost.
Proposed alternate flows that require less effort/clicks:
- Try to add expense and it fails with error message but it provides an easy one click button to add them
- and or the expense auto saves as a draft if it failed so that you can easily come back to it
- and or in the group details page, if you aren’t friends with someone in the group, there is a button next to their name that you can click to easily add them
- and or make the main search box a one stop shop so you can search both existing friends and new friends
Bradley Bernard
complete
Bradley Bernard
Thanks for the detailed feedback! This has been a long standing hard to catch bug, but I'm happy to report I was able to reproduce it and fix it today, so it should hopefully be gone!
For others looking at this, the error message pops up to ensure that users who owe each other, are friends with each other, since that is how balances are surfaced in the user interface.
The error message is data integrity related, but that doesn't explain why it _is_ showing up. That is the real bug, where any user added to a group, should automatically have all other group members added as friends by default. In some cases, this wasn't happening, so you'd have a new member in your group, yet you couldn't add expenses to the group since they weren't friends with the others.
A main use case that I just fixed: adding a new user by email, to a group, even though you were friends with them already. This is now solved, so the bug should appear much much less often, as I think this was the main culprit from my investigations on this occurring.
If it happens again, please let me know!